README of hash index - Mailing list pgsql-hackers

From Amit Kapila
Subject README of hash index
Date
Msg-id CAA4eK1+wZGFx7C3=Z8G4fYXATuFj6Jf3Fbkc5FB1dniKpBTkCg@mail.gmail.com
Whole thread Raw
Responses Re: README of hash index  (Kenneth Marshall <ktm@rice.edu>)
Re: README of hash index  (Jeff Janes <jeff.janes@gmail.com>)
List pgsql-hackers
Currently README of hash module contain algorithms written in below form.

The insertion algorithm is rather similar:

pin meta page and take buffer content lock in shared mode
loop:
compute bucket number for target hash key
release meta page buffer content lock
if (correct bucket page is already locked)
break
release any existing bucket page lock (if a concurrent split happened)
take heavyweight bucket lock in shared mode
retake meta page buffer content lock in shared mode
-- (so far same as reader)
release pin on metapage
..
..

I have mostly updated them in the patches I have proposed to improve
hash index.  However, each time I try to update them, I find that it
is easy to follow the code than to read and understand the existing
algorithm written in above form from README.

Do others find it useful to maintain the algorithms in above form?

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Sachin Kotwal
Date:
Subject: Why postgres take RowExclusiveLock on all partition
Next
From: Rajkumar Raghuwanshi
Date:
Subject: Re: Partition-wise join for join between (declaratively) partitioned tables