Re: [HACKERS] Getting server crash on Windows when using ICU collation - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: [HACKERS] Getting server crash on Windows when using ICU collation
Date
Msg-id CAA4eK1+rWoKv29_sibvdJd_F74PoiPCe3OV0GoA5R2kxZ0Q2Fg@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Getting server crash on Windows when using ICU collation  (Ashutosh Sharma <ashu.coek88@gmail.com>)
Responses Re: [HACKERS] Getting server crash on Windows when using ICUcollation
List pgsql-hackers
On Tue, Jun 20, 2017 at 9:06 AM, Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
> Hi,
>
> On Tue, Jun 20, 2017 at 2:36 AM, Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>> On 6/19/17 00:42, Ashutosh Sharma wrote:
>>>> If we don't find unconv, isn't it better to fall back to non-UTF8
>>>> version rather than saying command not found?
>>> Well, if any of the ICU package is installed on our system then we
>>> will certainly find uconv command. The only case where we can see such
>>> error is when user doesn't have any of the ICU packages installed on
>>> their system and are somehow trying to perform icu enabled build and
>>> in such case the build configuration has to fail which i think is the
>>> expected behaviour. Anyways, it is not uconv that decides whether we
>>> should fallback to non-UTF8 or not. It's the ICU version that decides
>>> whether to stick to UTF8 or fallback to nonUTF8 version. Thanks.
>>
>> How do we know we're running the uconv command from the installation
>> that we will compile against?
>
> Okay, I think, you are talking about the case where we may have
> multiple ICU versions installed on our system and there might be a
> possibility that the uconv command may get executed from the ICU
> version that we are not trying to link with postgres.
>

To avoid that why can't we use the same icu path for executing uconv
as we are using for linking?


-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Mahendranath Gurram
Date:
Subject: Re: [HACKERS] Regarding Postgres Dynamic Shared Memory (DSA)
Next
From: Dilip Kumar
Date:
Subject: Re: [HACKERS] Default Partition for Range