On Wed, Jan 20, 2021 at 3:27 PM Greg Nancarrow <gregn4422@gmail.com> wrote:
>
> On Fri, Jan 8, 2021 at 8:16 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > >
> > > I'm not sure if the problem of missing targetlist should be handled here (BTW,
> > > NIL is the constant for an empty list, not NULL). Obviously this is a
> > > consequence of the fact that the ModifyTable node has no regular targetlist.
> > >
> >
> > I think it is better to add comments along with this change. In this
> > form, this looks quite hacky to me.
> >
>
> The targetlist on the ModifyTable node has been setup correctly, but
> it hasn't been propagated to the Gather node.
> Of course, I have previously tried to elegantly fix this, but struck
> various problems, using different approaches.
> Perhaps this code could just be moved into set_plan_refs().
> For the moment, I'll just keep the current code, but I'll add a FIXME
> comment for this.
> I'll investigate Antonin's suggestions as a lower-priority side-task.
>
+1, that sounds like a good approach because anyway this has to be
dealt for the second patch and at this point, we should make the first
patch ready.
--
With Regards,
Amit Kapila.
