On Fri, Mar 20, 2020 at 8:24 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
>
> On Fri, Mar 20, 2020 at 04:58:08PM +0530, Amit Kapila wrote:
> > See, how the attached looks? I have written a commit message as well,
> > see if I have missed anyone is from the credit list?
>
> Thanks for looking again.
>
> Couple tweaks:
>
I have addressed your comments in the attached patch. Today, while
testing error messages from various phases, I noticed that the patch
fails to display error context if the error occurs during the truncate
phase. The reason was that we had popped the error stack in
lazy_scan_heap due to which it never calls the callback. I think we
need to set up callback at a higher level as is done in the attached
patch. I have done the testing by inducing errors in various phases
and it prints the required information. Let me know what you think of
the attached?
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
