Postgres Pro
Downloads
Home   >   mailing lists

Re: Log a warning in pg_createsubscriber for max_slot_wal_keep_size - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Log a warning in pg_createsubscriber for max_slot_wal_keep_size
Date
Msg-id CAA4eK1+h4WumWRrKNBk+vbEsLpPJXvGzkJXwdDeym4TC87OZjw@mail.gmail.com
Whole thread Raw
In response to Re: Log a warning in pg_createsubscriber for max_slot_wal_keep_size  (vignesh C <vignesh21@gmail.com>)
List pgsql-hackers
Tree view 
On Thu, Jan 23, 2025 at 6:42 PM Shubham Khanna
<khannashubham1197@gmail.com> wrote:
>
> Fixed the given comments. The attached patch contains the suggested changes.
>

I am fine with giving a WARNING for max_slot_wal_keep_size but I don't
think we need a test for each and every setting required for
pg_createsubscriber. This will add time to the tests without adding
much value. So, I don't think this patch deserves an additional test.

--
With Regards,
Amit Kapila.

pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: New buildfarm animals with FIPS mode enabled
Next
From: Shlok Kyal
Date:
Subject: Re: Restrict copying of invalidated replication slots