Re: Logging WAL when updating hintbit - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Logging WAL when updating hintbit
Date
Msg-id CAA4eK1+cJLAvh-a9ih=g8npYgchRK_3qPZ-DQFR6NciLVuactg@mail.gmail.com
Whole thread Raw
In response to Re: Logging WAL when updating hintbit  (Heikki Linnakangas <hlinnakangas@vmware.com>)
Responses Re: Logging WAL when updating hintbit
Re: Logging WAL when updating hintbit
List pgsql-hackers
On Fri, Dec 13, 2013 at 7:57 PM, Heikki Linnakangas
<hlinnakangas@vmware.com> wrote:
> On 12/13/2013 07:55 AM, Sawada Masahiko wrote:
>>
>> On Fri, Dec 13, 2013 at 1:51 PM, Dilip kumar <dilip.kumar@huawei.com>
>> wrote:
>>>
>>> On 04 December 2013, Sawada Masahiko Wrote
>>>
>> I have modified the patch base on your comment, and I attached the v7
>> patch.
>
>
> Thanks, committed with some minor changes:

Should this patch in CF app be moved to Committed Patches or is there
something left for this patch?

>> I'm not totally satisfied with the name of the GUC, wal_log_hintbits.

> Me either; at the very least, it's short an underscore: wal_log_hint_bits
> would be more readable.  But how about just "wal_log_hints"?

+1 for wal_log_hints, it sounds better.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: KONDO Mitsumasa
Date:
Subject: Re: Optimize kernel readahead using buffer access strategy
Next
From: Amit Kapila
Date:
Subject: Re: [bug fix] pg_ctl always uses the same event source