Re: pg_copy_logical_replication_slot doesn't copy the failover property - Mailing list pgsql-hackers

On Mon, Feb 24, 2025 at 4:29 PM Zhijie Hou (Fujitsu)
<houzj.fnst@fujitsu.com> wrote:
>
> Here is the new V3 patch set which updated the comments to make the
> issue clearer.
>

I pushed your first patch after minor modifications.

> After thinking more on the two_phase option, I didn't find an issue that prevent
> us from copying its option value.
>

Please see the comments atop ReplicationSlotCreate() and study the
commit 19890a064ebf53dedcefed0d8339ed3d449b06e6 to understand the
reasons as to why we initially enabled only at create time. It is
possible that the risk mentioned in the commit doesn't hold true for
copy_slot functionality but can you please analyze the same and let us
know your thoughts on the same?

> So, it’s more intuitive to me to just
> copy its value instead of adding doc for it. The 0002 includes the same and I will
> keep testing to ensure there are no other issues missed.
>

It is better to start a separate thread to discuss copying two_phase
property. Even, if it ends with just some comments and doc change, it
deserves an independent discussion.

--
With Regards,
Amit Kapila.