Re: old_snapshot_threshold allows heap:toast disagreement - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: old_snapshot_threshold allows heap:toast disagreement
Date
Msg-id CAA4eK1+Wo2Uxvr8Zbf4J6j93=y7mpDLu1tC7a9F2JesqAVQ4wg@mail.gmail.com
Whole thread Raw
In response to Re: old_snapshot_threshold allows heap:toast disagreement  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: old_snapshot_threshold allows heap:toast disagreement
List pgsql-hackers
On Fri, Jul 29, 2016 at 1:10 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Wed, Jul 27, 2016 at 7:26 PM, Andres Freund <andres@anarazel.de> wrote:
>
> New version attached.
>

+static inline void
+InitToastSnapshot(Snapshot snapshot, XLogRecPtr lsn)
+{
+ snapshot->satisfies = HeapTupleSatisfiesToast;
+ snapshot->lsn = lsn;
+}

Here, don't you need to initialize whenTaken as that is also used in
TestForOldSnapshot_impl() to report error "snapshot too old".


-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pg_dumping extensions having sequences with 9.6beta3
Next
From: Greg Stark
Date:
Subject: Re: [BUGS] BUG #14244: wrong suffix for pg_size_pretty()