cleanup in code - Mailing list pgsql-hackers

From Amit Kapila
Subject cleanup in code
Date
Msg-id CAA4eK1+Vk5z6V=xsKHsw9_0US=LbgE6i-GksEvSyqNX59zuZRg@mail.gmail.com
Whole thread Raw
Responses Re: cleanup in code  (Heikki Linnakangas <hlinnakangas@vmware.com>)
List pgsql-hackers
1. compiling with msvc shows warning in relcache.c
1>e:\workspace\postgresql\master\postgresql\src\backend\utils\cache\relcache.c(3959):
warning C4715: 'RelationGetIndexAttrBitmap' : not all control paths
return a value

Attached patch remove_msvc_warning.patch to remove above warning

2. It seems option K is not used in pg_dump:
    while ((c = getopt_long(argc, argv,
"abcCd:E:f:F:h:ij:K:n:N:oOp:RsS:t:T:U:vwWxZ:",
                                     long_options, &optindex)) != -1)
    I have checked both docs and code but didn't find the use of this option.
    Am I missing something here?

    Attached patch remove_redundant_option_K_pgdump.patch to remove this option
    from code.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: INSERT...ON DUPLICATE KEY LOCK FOR UPDATE
Next
From: knizhnik
Date:
Subject: Re: [ANNOUNCE] IMCS: In Memory Columnar Store for PostgreSQL