Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP. - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.
Date
Msg-id CAA4eK1+S7h2Tp6hWuEXyVNNrBNeO91pxJNSp3NmNL34FxHZbbQ@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
On Tue, Sep 6, 2022 at 7:40 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> > > I think they should say something like
> > >
> > > "logical replication starts skipping transaction with LSN %X/%X"
> > > "logical replication completed skipping transaction with LSN %X/%X"
> > >
> >
> > This looks better to me.
>
> +1
>
> > If you find the above argument to
> > differentiate between the start and end LSN convincing then we can
> > think of replacing "with" in the above messages with "finished at". I
> > see your point related to using "finished at" for PREPARE may not be a
> > good idea but I don't have better ideas for the same.
>
> Given that the user normally doesn't need to be aware of the
> difference between start LSN and end LSN in the context of using this
> feature, I think we can use "with LSN %X/%X".
>

Fair enough.

Alvaro, would you like to push your proposed change? Otherwise, I am
happy to take care of this.

-- 
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: more descriptive message for process termination due to max_slot_wal_keep_size
Next
From: David Rowley
Date:
Subject: Re: Reducing the chunk header sizes on all memory context types