Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided. - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.
Date
Msg-id CAA4eK1+PnwEb-bMXHrK1t401dJT-_-XoB=7h+QEcbSEWL-S==A@mail.gmail.com
Whole thread Raw
In response to Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.  (Shubham Khanna <khannashubham1197@gmail.com>)
Responses Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.
List pgsql-hackers
On Wed, Mar 26, 2025 at 4:02 PM Shubham Khanna
<khannashubham1197@gmail.com> wrote:
>

Let's combine 0001 and 0002.

A few minor comments:
*
+       If database name is not specified in publisher-server, it will try to
+       connect with postgres/template1 database to fetch the databases from
+       primary.

Can we change the above to: "If the database name is not specified in
publisher-server, the postgres database will be used, or if that does
not exist, template1 will be used."

*
+       Create one subscription on the target server for each non-template
+       database on the source server that allows connections, excluding
+       template databases or databases with connection restrictions.

The following text proposed by Euler seems better: "Create one
subscription per database on the target server. Exceptions are
template databases and databases that don't allow connections."

Please use this one at the above and other places where required.

--
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Fix slot synchronization with two_phase decoding enabled
Next
From: Vladlen Popolitov
Date:
Subject: Re: Remove useless casts to (char *)