On Thu, Jul 1, 2021 at 8:00 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> I find the business with OPT_NONE a bit uselessly verbose. It's like we
> haven't completely made up our minds that zero means no options set.
> Wouldn't it be simpler to remove that #define and leave the variable
> uninitialized until we want to set the options we want, and then use
> plain assignment instead of |= ?
>
Yeah, that makes sense. I have removed its usage from
CreateSubscription but I think we can get rid of it entirely as well.
The latest patch sent by Bharath looks good to me. Would you like to
commit it or shall I take care of it?
--
With Regards,
Amit Kapila.
