Re: [PATCH] pg_hba.conf error messages for logical replication connections - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: [PATCH] pg_hba.conf error messages for logical replication connections
Date
Msg-id CAA4eK1+Ebvc+pLXBBRFEUtLmozOjhrb-v9deCG_-0X+tzPgQVw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] pg_hba.conf error messages for logical replication connections  (Paul Martinez <paulmtz@google.com>)
Responses Re: [PATCH] pg_hba.conf error messages for logical replication connections
List pgsql-hackers
On Tue, Feb 2, 2021 at 1:43 AM Paul Martinez <paulmtz@google.com> wrote:
>
> On Fri, Jan 29, 2021 at 8:41 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > Yeah, hints or more details might improve the situation but I am not
> > sure we want to add more branching here. Can we write something
> > similar to HOSTNAME_LOOKUP_DETAIL for hints? Also, I think what you
> > are proposing to write is more of a errdetail kind of message. See
> > more error routines in the docs [1].
> >
>
> Alright, I've updated both sets of error messages to use something like
> HOSTNAME_LOOKUP_DETAIL, both for the error message itself, and for the
> extra detail message about the replication keyword. Since now we specify
> both an errdetail (sent to the client) and an errdetail_log (sent to the
> log), I renamed HOSTNAME_LOOKUP_DETAIL to HOSTNAME_LOOKUP_DETAIL_LOG.
>

I don't think we need to update the error messages, it makes the code
a bit difficult to parse without much benefit. How about just adding
errdetail? See attached and let me know what you think?

-- 
With Regards,
Amit Kapila.

Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Hybrid Hash/Nested Loop joins and caching results from subplans
Next
From: Matthias van de Meent
Date:
Subject: Re: progress reporting for partitioned REINDEX