Re: pgoutput: comment atop rel_sync_cache_publication_cb() has an inconsistency - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: pgoutput: comment atop rel_sync_cache_publication_cb() has an inconsistency
Date
Msg-id CAA4eK1+7-C0ZpTn=A8swmnwN_J4g_BEyYpKXk6iFgz6ZMj_WJw@mail.gmail.com
Whole thread Raw
In response to pgoutput: comment atop rel_sync_cache_publication_cb() has an inconsistency  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
List pgsql-hackers
On Tue, Mar 25, 2025 at 8:31 AM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
>
> Dear hackers,
>
> While reading the code, I found $SUBJECT. It says:
>
> ```
> /*
>  * Publication relation/schema map syscache invalidation callback
>  *
>  * Called for invalidations on pg_publication and pg_namespace.
>  */
> static void
> rel_sync_cache_publication_cb(Datum arg, int cacheid, uint32 hashvalue)
> ```
>
> But this won't be called for invalidating pg_publication. It should have been
> updated by 3abe9dc1, but it was an oversight.
>

Agreed and thanks for the patch.

--
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Add estimated hit ratio to Memoize in EXPLAIN to explain cost adjustment
Next
From: Amit Kapila
Date:
Subject: Re: Conflict detection for multiple_unique_conflicts in logical replication