Re: Snapbuild woes followup - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Snapbuild woes followup
Date
Msg-id CAA4eK1+6AWr18hDpQ1hbHmKdepWPPHTscY9mGEogznZ7mkWM1Q@mail.gmail.com
Whole thread Raw
In response to Re: Snapbuild woes followup  (Andres Freund <andres@anarazel.de>)
Responses Re: Snapbuild woes followup
List pgsql-hackers
On Tue, Jan 26, 2021 at 2:18 AM Andres Freund <andres@anarazel.de> wrote:
>
> Hi,
>
> On 2021-01-25 12:00:08 -0800, Andres Freund wrote:
> > > >   /*
> > > >    * For backward compatibility reasons this has to be stored in the wrongly
> > > >    * named field.  Will be fixed in next major version.
> > > >    */
> > > >   return builder->was_running.was_xmax;
> > >
> > > We could fix that now... Andres, what did you have in mind for a proper
> > > name?
> >
> > next_phase_at seems like it'd do the trick?
>

The new proposed name sounds good to me.

> See attached patch...

LGTM.

-- 
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Marco
Date:
Subject: [WIP] Reduce likelihood of fdw prepared statement collisions
Next
From: Masahiro Ikeda
Date:
Subject: Re: About to add WAL write/fsync statistics to pg_stat_wal view