On 29 May 2013 10:40, Neel Patel <neel.patel@enterprisedb.com> wrote:
> Hi Dave,
>
> Please find the updated patch after fixing some of the issues and comments
> given by Ashesh.
Just realised this reply has been in my draft folder for over a month...
This comment appears to be incomplete:
//While editing the view, if it is materialized view then only change
The section of if... else if... else if... that begins with:
if (name == wxT("autovacuum_vacuum_cost_delay"))
should probably use:
switch(name)
{
case wxT("autovacuum_vacuum_cost_delay")
case ...
}
Given the amount of duplicate functionality this shares with tables,
is there not a way there could be a common class they could both
inherit from to reduce maintenance overhead?
--
Thom
