Re: libpq: make PGresult* "const" in PQcmdStatus()/PQcmdTuples()? - Mailing list pgsql-interfaces

From Jeroen Vermeulen
Subject Re: libpq: make PGresult* "const" in PQcmdStatus()/PQcmdTuples()?
Date
Msg-id CA+zULE5W_AZ6in8y7qfhDwKhhsDOp=O+yAQd0WjqBFY-ELkb7g@mail.gmail.com
Whole thread Raw
In response to Re: libpq: make PGresult* "const" in PQcmdStatus()/PQcmdTuples()?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-interfaces

Ah, that explains.  Thanks.

On Sat, Dec 21, 2024, 16:56 Tom Lane <tgl@sss.pgh.pa.us> wrote:
Jeroen Vermeulen <jtvjtv@gmail.com> writes:
> Any objections to changing these two libpq functions' PGresult* parameters
> to be const?

> So "char * PQcmdStatus(PGresult *)" would become "char *PQcmdStatus(const
> PGresult *)", and "char *PQcmdTuples(PGresult *)" would become "char
> *PQcmdTuples(const PGresult *)".

Both of those return pointers to res->cmdStatus, so it would not make
any sense to const-ify the argument unless you also const-ify the
result; which would cause compiler warnings for users.  I'm pretty
sure we've explicitly rejected making this change for that reason.

                        regards, tom lane

pgsql-interfaces by date:

Previous
From: Tom Lane
Date:
Subject: Re: libpq: make PGresult* "const" in PQcmdStatus()/PQcmdTuples()?
Next
From: Tom Lane
Date:
Subject: Re: libpq: make PGresult* "const" in PQcmdStatus()/PQcmdTuples()?