Fixed PPAS trigger column view condition - Mailing list pgadmin-hackers

From Sanket Mehta
Subject Fixed PPAS trigger column view condition
Date
Msg-id CA+yw=mP2SqS--tBeCFfNAZHqP2pBay+2mxJxeW=pMEtdre=zig@mail.gmail.com
Whole thread Raw
Responses Re: Fixed PPAS trigger column view condition
List pgadmin-hackers
Hi Dave,

There is one issue with pgadmin while viewing the trigger definition created for PPAS server as below:

CREATE OR REPLACE TRIGGER tr_a
  BEFORE UPDATE OF cl1 ON a FOR EACH ROW
begin
if(:new.cl1 < 0) then
 insert into a values (:new.*); 
 END if;
END;

after creating the trigger using above query,column name cl1(highlighted part above) is not visible in property window for that trigger.

In current implementation, there is a condition:

GetLanguage() != wxT("edbspl") in

 ShowTreeDetail() and ReadColumnDetails() functions in pgTrigger.cpp file which will prevent it to fetch column name in case db server is PPAS.

I have removed that condition and tested it. It works fine now.
I have attached the same patch with this mail for your reference.
Please review it and if it looks good to you please do the needful.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin III commit: Fix copyright date.
Next
From: Dave Page
Date:
Subject: Re: Fixed PPAS trigger column view condition