On Thu, Sep 26, 2019 at 2:13 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>
> Hello Paul, I've started to review this patch. Here's a few minor
> things I ran across -- mostly compiler warnings (is my compiler too
> ancient?). You don't have to agree with every fix -- feel free to use
> different fixes if you have them. Also, feel free to squash them onto
> whatever commit you like (I think they all belong onto 0001 except the
> last which seems to be for 0002).
Hi Alvaro, sorry, I missed your note from September. I really
appreciate your review and will take a look at your suggested changes!
I just opened this thread to post a rebased set patches (especially
because of the `const` additions to range functions). Maybe it's not
that helpful since they don't include your changes yet but here they
are anyway. I'll post some more with your changes shortly.
> Did you not push your latest version to your github repo? I pulled from
> there and branch 'multirange' does not seem to match what you posted.
Hmm, I'll take a look. Before I made the v3 files I switched to
multirange-patch so I could squash things and use git to generate one
patch file per commit. So `multirange` isn't rebased as currently as
`multirange-patch`. If you don't mind a force-push I can update
`multirange` to be the same.
Yours,
Paul
