Re: Segfault when restoring -Fd dump on current HEAD - Mailing list pgsql-hackers

From Dmitry Dolgov
Subject Re: Segfault when restoring -Fd dump on current HEAD
Date
Msg-id CA+q6zcXx0XHqLsFJLaUU2j5BDiBAHig=YRoBC_YVq7VJGvzBEA@mail.gmail.com
Whole thread Raw
In response to Re: Segfault when restoring -Fd dump on current HEAD  (Andres Freund <andres@anarazel.de>)
Responses Re: Segfault when restoring -Fd dump on current HEAD
List pgsql-hackers
> On Mon, Mar 4, 2019 at 7:15 PM Andres Freund <andres@anarazel.de> wrote:
>
> The pluggable storage patchset contains exactly that... I've attached
> the precursor patch (CREATE ACCESS METHOD ... TYPE TABLE), and the patch
> for pg_dump support. They need a bit more cleanup, but it might be
> useful information for this thread.

Didn't expect this to happen so quickly, thanks!

> On 2019-03-04 13:25:40 -0500, Tom Lane wrote:
> > Andres Freund <andres@anarazel.de> writes:
> > >
> > > But it does basically require breaking archive compatibility.  I
> > > personally am OK with that, but I thought it might be worth discussing.
> >
> > I don't recall there being huge pushback when we did that in the past,
> > so I'm fine with it as long as there's an identifiable feature making
> > it necessary.
>
> Cool.

Then I guess we need to add the attached patch on top of a pg_dump support for
table am. It contains changes to use NULL as a default value for owner / defn /
dropStmt (exactly what we've changed back in 19455c9f56), and doesn't crash,
since K_VERS is different.

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Should we increase the default vacuum_cost_limit?
Next
From: David Rowley
Date:
Subject: Re: [HACKERS] PATCH: multivariate histograms and MCV lists