Re: [HACKERS] Bug in to_timestamp(). - Mailing list pgsql-hackers

From Dmitry Dolgov
Subject Re: [HACKERS] Bug in to_timestamp().
Date
Msg-id CA+q6zcXjG34kQy_hskZQjhajFCR8XhfHsHXL2orB4te2Vwdmbg@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Bug in to_timestamp().  (Dmitry Dolgov <9erthalion6@gmail.com>)
Responses Re: [HACKERS] Bug in to_timestamp().  (Arthur Zakirov <a.zakirov@postgrespro.ru>)
List pgsql-hackers
> On 18 February 2018 at 18:49, Dmitry Dolgov <9erthalion6@gmail.com> wrote:
> > On 17 February 2018 at 10:02, Arthur Zakirov <a.zakirov@postgrespro.ru> wrote:
> > > On Wed, Feb 14, 2018 at 05:23:53PM +0100, Dmitry Dolgov wrote:
> > >
> > > SELECT to_timestamp('2000 + JUN', ' /') FROM dual
> > > ORA-01830: date format picture ends before converting entire input string
> > >
> > > SELECT to_timestamp('2000 + JUN', ' ') FROM dual
> > > ORA-01830: date format picture ends before converting entire input string
> > >
> > > It's sort of corner case, but anyway maybe you would be interested to handle
> > > it.
> >
> > I think it could be fixed by another patch. But I'm not sure that it
> > will be accepted as well as this patch :).
>
> Why do you think there should be another patch for it?

Just to make myself clear. I think it's fair enough to mark this patch as ready
for committer - the implementation is neat and sufficient as for me, and it
provides a visible improvement for user experience. The question above is
probably the only thing that prevents me from proposing this.

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Hash Joins vs. Bloom Filters / take 2
Next
From: Bruce Momjian
Date:
Subject: Re: Better Upgrades