Re: [HACKERS] Create subscription with `create_slot=false` andincorrect slot name - Mailing list pgsql-hackers

From Dmitry Dolgov
Subject Re: [HACKERS] Create subscription with `create_slot=false` andincorrect slot name
Date
Msg-id CA+q6zcXQqHqhiFR-eLvVk+x9CvPLvJotyqQ77Q1U_4Uj+BLW4g@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Create subscription with `create_slot=false` andincorrect slot name  (Kuntal Ghosh <kuntalghosh.2007@gmail.com>)
List pgsql-hackers
On 23 May 2017 at 07:26, Euler Taveira <euler@timbira.com.br> wrote:
>
> ReplicationSlotValidateName() should be called in parse_subscription_options() to avoid a pilot error.
> IMHO we should prevent a future error (use of invalid slot name).

Yes, I see now. I assume this little patch should be enough for that.

Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: [HACKERS] Regression in join selectivity estimations when usingforeign keys
Next
From: tushar
Date:
Subject: [HACKERS] ALTER SUBSCRIPTION ..SET PUBLICATION refresh is notthrowing error.