Re: New GUC to sample log queries - Mailing list pgsql-hackers

From Dmitry Dolgov
Subject Re: New GUC to sample log queries
Date
Msg-id CA+q6zcVirXHe7ZGGDMOn0dmWNbXzkwih-+h96MZmKvSWzHbz+Q@mail.gmail.com
Whole thread Raw
In response to Re: New GUC to sample log queries  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
Responses Re: New GUC to sample log queries  (Adrien Nayrat <adrien.nayrat@anayrat.info>)
List pgsql-hackers
> On Mon, Nov 19, 2018 at 2:40 PM Tomas Vondra <tomas.vondra@2ndquadrant.com> wrote:
>
> On 11/19/18 2:57 AM, Michael Paquier wrote:
> > On Sun, Nov 18, 2018 at 12:18:33PM +0100, Dmitry Dolgov wrote:
> >> Since it's hard to come up with a concise name that will mention sampling rate
> >> in the context of min_duration_statement, I think it's fine to name this
> >> configuration "log_sample_rate", as long as it's dependency from
> >> log_min_duration_statements is clearly explained in the documentation.
> >
> > log_sample_rate looks fine to me as a name.
>
> That seems far too short to me - the name should indicate it applies to
> statement logging. I'd say log_statement_sample_rate is better.

I agree, sounds reasonable.


pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: New GUC to sample log queries
Next
From: Alvaro Herrera
Date:
Subject: Re: heap_sync seems rather oblivious to partitioned tables(wal_level=minimal)