Re: Reduce amount of WAL generated by CREATE INDEX for gist, gin and sp-gist - Mailing list pgsql-hackers

From Dmitry Dolgov
Subject Re: Reduce amount of WAL generated by CREATE INDEX for gist, gin and sp-gist
Date
Msg-id CA+q6zcUmB4i1jQUBc1YU6zppV+u4ADjc05M1f-S3UJGW_0A7Sw@mail.gmail.com
Whole thread Raw
In response to Re: Reduce amount of WAL generated by CREATE INDEX for gist, gin andsp-gist  (Andrey Lepikhov <a.lepikhov@postgrespro.ru>)
Responses Re: Reduce amount of WAL generated by CREATE INDEX for gist, gin andsp-gist  (Andrey Lepikhov <a.lepikhov@postgrespro.ru>)
List pgsql-hackers
> On Tue, Jul 31, 2018 at 6:36 AM Andrey Lepikhov <a.lepikhov@postgrespro.ru> wrote:
>
> With the consent of Anastasia I will improving this patch further.
> Attachment contains next version of the patch set.

Thank you. I played a bit with this patch, and can confirm visible WAL size
reduction (it's rather obvious, but still). Although, probably due to lack of
my knowledge here, I wonder how does it work when an index is build
concurrently?

> Benchmarks:
> -----------
>
> Test: pgbench -f gin-WAL-test.sql -t 5:
> ---------------------------------------
> master:
> Latency average: 27696.299 ms
> WAL size: 2.66 GB

Does it makes sense to measure latency of the entire script, since it contains
also some preparation work? Of course it still shows the difference between
patched version and master, but probably in a more noisy way.

I'm moving this patch to the next CF.


pgsql-hackers by date:

Previous
From: "Matsumura, Ryo"
Date:
Subject: RE: [PROPOSAL]a new data type 'bytea' for ECPG
Next
From: Dmitry Dolgov
Date:
Subject: Re: Speeding up text_position_next with multibyte encodings