Home > mailing lists

Re: [HACKERS] [PATCH] Generic type subscription - Mailing list pgsql-hackers

From	Dmitry Dolgov
Subject	Re: [HACKERS] [PATCH] Generic type subscription
Date	January 8, 2017 15:36:32
Msg-id	CA+q6zcUHExgx8G_BXQ2X+ZkRkZTAWZOvk4K9-NyRBevGA479Fw@mail.gmail.com Whole thread Raw
In response to	Re: [HACKERS] [PATCH] Generic type subscription (Artur Zakirov <a.zakirov@postgrespro.ru>)
Responses	Re: [HACKERS] [PATCH] Generic type subscription (Dmitry Dolgov <9erthalion6@gmail.com>)
List	pgsql-hackers

> On 4 January 2017 at 18:06, Artur Zakirov <a.zakirov@postgrespro.ru> wrote:

> But I'm not convinced about how to distinguish ArrayRef node with new

> SubscriptingRef node.

I'm not sure I understood you correctly. You're talking about having two nodes

`ArrayRef` and `SubscriptingRef` at the same time for the sake of backward

compatibility, am I right? But they're basically the same, since

`SubscriptingRef` name is used just to indicate more general purpose of this

node.

> Also Tom pointed that he had bad experience with using ArrayRef node:

Yes, but it was related to the idea of having `ArrayRef` and `JsonbRef` nodes

for specific types. Since now there is generic `SubscriptingRef` node, I think

it should be ok.

>> Hm...I already answered, that I managed to avoid compilation problems for

>> this particular extension using the `genparser` command again:

> I suppose that a separate node type could solve it.

Just to be clear - as far as I understood, these compilation problems were

caused not because the extension knew something about ArrayRef node in

particular, but because the extension tried to extract all nodes to generate

code from them. It means any change will require "refetching", so I think it's

natural for this extension.

From: Fabien COELHO
Date: 08 January 2017, 15:20:59
Subject: Re: [HACKERS] proposal: session server side variables (fwd)

From: Gavin Flower
Date: 08 January 2017, 15:59:10
Subject: Re: [HACKERS] RustgreSQL