Re: Vectored I/O in bulk_write.c - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Vectored I/O in bulk_write.c
Date
Msg-id CA+hUKGLzgXSC026GjSuNXFthcAzskeM5msxQkDKquuOy6Dn1FQ@mail.gmail.com
Whole thread Raw
In response to Re: Vectored I/O in bulk_write.c  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: Vectored I/O in bulk_write.c
List pgsql-hackers
Alright, here is a first attempt at merging all three interfaces as
you suggested.  I like it!  I especially like the way it removes lots
of duplication.

I don't understand your argument about the location of the
write-vs-extent assertions.  It seems to me that these are assertions
about what the *public* smgrnblocks() function returns.  In other
words, we assert that the caller is aware of the current relation size
(and has some kind of interlocking scheme for that to be possible),
according to the smgr implementation's public interface.  That's not
an assertion about internal details of the smgr implementation, it's
part of the "contract" for the API.

Attachment

pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: Add basic tests for the low-level backup method.
Next
From: Heikki Linnakangas
Date:
Subject: Re: Vectored I/O in bulk_write.c