Re: Importing pg_bsd_indent into our source tree - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Importing pg_bsd_indent into our source tree
Date
Msg-id CA+hUKGLsXfNh6AZYAbUb39-fxQ_WKV-a0h7XaWk9ZHWCpX2bOg@mail.gmail.com
Whole thread Raw
In response to Re: Importing pg_bsd_indent into our source tree  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sun, Feb 12, 2023 at 2:44 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I wrote:
> > Hmmm ... ci autoconf build is now happy, but the Windows run complains
> > that none of the output files match.  I'm betting that this is a
> > Windows-newline problem, since I now see that indent.c opens both the
> > input and output files in default (text) mode.  I'm inclined to
> > change it to open the output file in binary mode while leaving the
> > input in text, which should have the effect of stripping \r if it's
> > present.
>
> So let's see if that theory is correct at all ...

(Since I happened to be tinkering on cfbot while you posted these, I
noticed that cfbot took over 50 minutes to start processing the v4.
The problem was upstream: the time in the second-last column of
https://commitfest.postgresql.org/42/ didn't change for that whole
time, even though the archives had your new email.  Cf castles, sand;
I should probably get a better trigger mechanism :-)  I like that page
because it lets me poll one single end point once per minute to learn
about changes across all threads, but I am not sure what sort of
technology connects the archives to the CF app, and how it can fail.)



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Importing pg_bsd_indent into our source tree
Next
From: David Rowley
Date:
Subject: Making aggregate deserialization (and WAL receive) functions slightly faster