Re: pgsql: Preallocate some DSM space at startup. - Mailing list pgsql-committers

From Thomas Munro
Subject Re: pgsql: Preallocate some DSM space at startup.
Date
Msg-id CA+hUKGLrmN9Mz3K4q58rxhuhirr_9dXFBs5rvGT59Q15ZvYfeQ@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Preallocate some DSM space at startup.  (Michael Paquier <michael@paquier.xyz>)
List pgsql-committers
On Fri, Jul 31, 2020 at 6:26 PM Michael Paquier <michael@paquier.xyz> wrote:
> longfin is complaning on this one:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=longfin&dt=2020-07-31%2005%3A59%3A08
> guc.c:2241:38: error: implicit conversion from 'unsigned long' to
> 'int' changes value from 17592186044415 to -1
> [-Werror,-Wconstant-conversion]
>                 0, 0, Min(INT_MAX, SIZE_MAX / 1024 / 1024),
>                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~

Thanks.  I pushed a fix after checking on Clang 11 and GCC 8 that it's
warning-free and produces the value I want on 32 and 64 bit builds.



pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Fix compiler warning from Clang.
Next
From: Tom Lane
Date:
Subject: pgsql: Fix recently-introduced performance problem in ts_headline().