Re: pgsql: Add PSQL_WATCH_PAGER for psql's \watch command. - Mailing list pgsql-committers

From Thomas Munro
Subject Re: pgsql: Add PSQL_WATCH_PAGER for psql's \watch command.
Date
Msg-id CA+hUKGLpSgVmD1jMpBcsjnXun3jNxG+6dYzpocxOz3R6Z8n9rA@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Add PSQL_WATCH_PAGER for psql's \watch command.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Add PSQL_WATCH_PAGER for psql's \watch command.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Tue, Jul 13, 2021 at 12:30 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Thomas Munro <tmunro@postgresql.org> writes:
> > To make \watch react quickly when the user quits the pager or presses
> > ^C, and also to increase the accuracy of its timing and decrease the
> > rate of useless context switches, change the main loop of the \watch
> > command to use sigwait() rather than a sleeping/polling loop, on Unix.
>
> I think this is going to fall over on gaur, which doesn't have POSIX-style
> sigwait.  We've escaped dealing with that so far because our only existing
> use of sigwait is hidden under
>
> #if defined(ENABLE_THREAD_SAFETY) && !defined(WIN32)
>
> Perhaps the easiest answer is to make the #if conditional for this
> code look like that too.

Oh, thanks for the advance warning.   Wouldn't HAVE_SIGWAIT be better?  Like so.

Attachment

pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: Re: pgsql: Fix theoretical bug in tuplesort
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Add PSQL_WATCH_PAGER for psql's \watch command.