Re: Suppressing useless wakeups in walreceiver - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Suppressing useless wakeups in walreceiver
Date
Msg-id CA+hUKGLSsr-KbgaEpGwsKBOa=M5oh9VtrNgRSvX-qohuYptQJA@mail.gmail.com
Whole thread Raw
In response to Re: Suppressing useless wakeups in walreceiver  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: Suppressing useless wakeups in walreceiver
Re: Suppressing useless wakeups in walreceiver
Re: Suppressing useless wakeups in walreceiver
List pgsql-hackers
On Tue, Nov 8, 2022 at 3:20 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> On Sun, Nov 6, 2022 at 12:01 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
> > Here is a new version of the patch that addresses this feedback.
>
> This looks pretty good to me.  Thanks for picking it up!  I can live
> with the change to use a global variable; it seems we couldn't quite
> decide what the scope was for moving stuff into a struct (ie various
> pre-existing stuff representing the walreceiver's state), but I'm OK
> with considering that as a pure refactoring project for a separate
> thread.  That array should be "static", though.

And with that change and a pgindent, pushed.



pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Reviving lost replication slots
Next
From: Masahiko Sawada
Date:
Subject: Re: Add index scan progress to pg_stat_progress_vacuum