Postgres Pro
Downloads
Home   >   mailing lists

Re: BUG #17928: Standby fails to decode WAL on termination of primary - Mailing list pgsql-bugs

From Thomas Munro
Subject Re: BUG #17928: Standby fails to decode WAL on termination of primary
Date
Msg-id CA+hUKGLOgGh=9siEhACUsrZEAQPVEQWgn35cggeci0_cNbPSSw@mail.gmail.com
Whole thread Raw
In response to Re: BUG #17928: Standby fails to decode WAL on termination of primary  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: BUG #17928: Standby fails to decode WAL on termination of primary  (Michael Paquier <michael@paquier.xyz>)
List pgsql-bugs
Tree view 
On Mon, Aug 14, 2023 at 3:56 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> On Mon, Aug 14, 2023 at 2:08 PM Michael Paquier <michael@paquier.xyz> wrote:
> > It seems to me that we should try to also finish the header validation
> > before attempting XLogReadRecordAlloc() on the total_len as well?  It
> > looks like the end result would be to move the first ReadPageInternal
> > done for the header with all its cross-page checks before
> > XLogReadRecordAlloc().  That should remove the need of having
> > gotheader from v1.
>
> Yeah.  Trying out an idea for how to untangle that...

Something like this... patches for 12 and master attached.  Needs a
lot more testing.  I really want to figure out how to get
deterministic tests...
Attachment

pgsql-bugs by date:

Previous
From: Thomas Munro
Date:
Subject: Re: BUG #17928: Standby fails to decode WAL on termination of primary
Next
From: PG Bug reporting form
Date:
Subject: BUG #18055: logical decoding core on AllocateSnapshotBuilder()