Re: Remove HeapTuple and Buffer dependency for predicate locking functions - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Remove HeapTuple and Buffer dependency for predicate locking functions
Date
Msg-id CA+hUKGLM6tTdECTRabO8VMU6xT6MU5cFbOTAUJxA_6KQ3XtsSg@mail.gmail.com
Whole thread Raw
In response to Re: Remove HeapTuple and Buffer dependency for predicate locking functions  (Ashwin Agrawal <aagrawal@pivotal.io>)
Responses Re: Remove HeapTuple and Buffer dependency for predicate locking functions
List pgsql-hackers
On Sat, Nov 9, 2019 at 8:41 AM Ashwin Agrawal <aagrawal@pivotal.io> wrote:
> On Thu, Nov 7, 2019 at 8:44 PM Thomas Munro <thomas.munro@gmail.com> wrote:
>> I'm planning to commit these three patches on Monday.  I've attached
>> versions with whitespace-only changes from pgindent, and commit
>> messages lightly massaged and updated to point to this discussion and
>> reviewers.
>
> Thanks a lot, sounds good.

Hi Ashwin,

I pushed the first two, but on another read-through of the main patch
I didn't like the comments for CheckForSerializableConflictOut() or
the fact that it checks SerializationNeededForRead() again, after I
thought a bit about what the contract for this API is now.  Here's a
version with small fixup that I'd like to squash into the patch.
Please let me know what you think, or if you see how to improve it
further.

Attachment

pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: cost based vacuum (parallel)
Next
From: Fujii Masao
Date:
Subject: Re: pg_waldump and PREPARE