Re: pg_upgrade verbosity when redirecting output to log file - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: pg_upgrade verbosity when redirecting output to log file
Date
Msg-id CA+hUKGKjrV61ZVJ8OSag+3rKRmCZXPc03bDyWMqhXg3rdZ=fOw@mail.gmail.com
Whole thread Raw
In response to Re: pg_upgrade verbosity when redirecting output to log file  (Bruce Momjian <bruce@momjian.us>)
Responses Re: pg_upgrade verbosity when redirecting output to log file
List pgsql-hackers
On Tue, Jan 11, 2022 at 4:42 AM Bruce Momjian <bruce@momjian.us> wrote:
> On Sun, Jan  9, 2022 at 10:39:58PM -0800, Andres Freund wrote:
> > On 2022-01-10 01:14:32 -0500, Tom Lane wrote:
> > > I think I'd vote for just nuking that output altogether.
> > > It seems of very dubious value.
> >
> > It seems worthwhile in some form - on large cluster in copy mode, the "Copying
> > user relation files" step can take *quite* a while, and even link/clone mode
> > aren't fast. But perhaps what'd be really needed is something counting up
> > actual progress in percentage of files and/or space...
> >
> > I think just coupling it to verbose mode makes the most sense, for now?
>
> All of this logging is from the stage where I was excited pg_upgrade
> worked, and I wanted to give clear output if it failed in some way ---
> printing the file names seems like an easy solution.  I agree at this
> point that logging should be reduced, and if they want more logging, the
> verbose option is the right way to get it.

+1



pgsql-hackers by date:

Previous
From: Stephan Doliov
Date:
Subject: Re: Observability in Postgres
Next
From: Andres Freund
Date:
Subject: Re: USE_BARRIER_SMGRRELEASE on Linux?