Re: Use streaming read API in ANALYZE - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Use streaming read API in ANALYZE
Date
Msg-id CA+hUKGKiuv86r_N3gykwB11J-q=gLXQzpGOw10x-jnmMH68RgA@mail.gmail.com
Whole thread Raw
In response to Re: Use streaming read API in ANALYZE  (Melanie Plageman <melanieplageman@gmail.com>)
List pgsql-hackers
On Thu, Aug 22, 2024 at 7:31 PM Mats Kindahl <mats@timescale.com> wrote:
> The alternate version proposed by Nazir allows you to decide which interface to use.
> Reverting the patch entirely would also solve the problem.
> Passing down the block sampler and the strategy to scan_begin() and move the ReadStream setup in analyze.c into
initscan()in heapam.c, but this requires adding new parameters to this function. 
> Having accessors that allow you to get the block sampler and strategy from the ReadStream object.

I'm a bit confused about how it can make sense to use the same
BlockSampler with a side relation/fork.  Could you point me at the
code?

> It would be great if this could be fixed before the PG17 release now that 27bc1772fc8 was reverted.

Ack.  Thinking...

Random thought: is there a wiki page or something where we can find
out about all the table AM projects?  For the successor to
27bc1772fc8, I hope they'll be following along.



pgsql-hackers by date:

Previous
From: shawn wang
Date:
Subject: Re: Trim the heap free memory
Next
From: Jubilee Young
Date:
Subject: Re: [PATCH] Guard `CLOBBER_FREED_MEMORY` & `MEMORY_CONTEXT_CHECKING`