Re: Extending SMgrRelation lifetimes - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Extending SMgrRelation lifetimes
Date
Msg-id CA+hUKGKVQLV9yC_LT=NcXwXNc5hXM7ad93q4z+-gO-uVQgGthQ@mail.gmail.com
Whole thread Raw
In response to Re: Extending SMgrRelation lifetimes  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: Extending SMgrRelation lifetimes
List pgsql-hackers
On Wed, Nov 29, 2023 at 1:42 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> I spent some more time digging into this, experimenting with different
> approaches. Came up with pretty significant changes; see below:

Hi Heikki,

I think this approach is good.  As I wrote in the first email, I had
briefly considered reference counting, but at the time I figured there
wasn't much point if it's only ever going to be 0 or 1, so I was
trying to find the smallest change.  But as you explained, there is
already an interesting case where it goes to 2, and modelling it that
way removes a weird hack, so it's a net improvement over the unusual
'owner' concept.  +1 for your version.  Are there any further tidying
or other improvements you want to make?

Typos in comments:

s/desroyed/destroyed/
s/receiveing/receiving/



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: src/bin/pg_upgrade/t/004_subscription.pl test comment fix
Next
From: Bharath Rupireddy
Date:
Subject: Re: Improve WALRead() to suck data directly from WAL buffers when possible