Shouldn't GSSAPI and SSL code use FeBeWaitSet? - Mailing list pgsql-hackers

From Thomas Munro
Subject Shouldn't GSSAPI and SSL code use FeBeWaitSet?
Date
Msg-id CA+hUKGK=m9dLrq42oWQ4XfK9iDjGiZVwpQ1HkHrAPfG7Kh681g@mail.gmail.com
Whole thread Raw
Responses Re: Shouldn't GSSAPI and SSL code use FeBeWaitSet?
List pgsql-hackers
Hi,

While working on a patch to reuse a common WaitEventSet for latch
waits, I noticed that be-secure-gssapi.c and be-secure-openssl.c don't
use FeBeWaitSet.  They probably should, for consistency with
be-secure.c, because that surely holds the socket they want, no?  The
attached patch passes the "ssl" and "kerberos" tests and reaches that
code, confirmed by adding some log messages.

I'm not actually sure what the rationale is for reporting "terminating
connection due to unexpected postmaster exit" here but not elsewhere.
I copied the error from be-secure.c.

Attachment

pgsql-hackers by date:

Previous
From: Hubert Zhang
Date:
Subject: Re: Yet another vectorized engine
Next
From: Thomas Munro
Date:
Subject: Re: Shouldn't GSSAPI and SSL code use FeBeWaitSet?