Re: fairywren hung in pg_basebackup tests - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: fairywren hung in pg_basebackup tests
Date
Msg-id CA+hUKGK5pbVbW2LL=ktJWhSE5_oYfbmC1iU1y0daBtm+HMN4sQ@mail.gmail.com
Whole thread Raw
In response to Re: fairywren hung in pg_basebackup tests  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
On Thu, Jul 28, 2022 at 12:41 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> I thought about putting it at the top, but don't we really only need
> to make an extra system call if MinGW's stat() told us it saw a
> directory?  And what if you asked to look through symlinks?  I thought
> about putting it near the S_ISLNK() test, which is the usual pattern,
> but then what if MinGW decides to add d_type support one day?  Those
> thoughts led to the attached formulation.  Untested.  I'll go and try
> to see if I can run this with Melih's proposed MSYS CI support...

Success.  I'll push this, and then hopefully those BF animals can be
unwedged.  (I see some unrelated warnings to look into.)

https://cirrus-ci.com/task/5253183533481984?logs=tests#L835



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Improve description of XLOG_RUNNING_XACTS
Next
From: Julien Rouhaud
Date:
Subject: Re: Official Windows Installer and Documentation