Re: BUG #17828: postgres_fdw leaks file descriptors on error and aborts aborted transaction in lack of fds - Mailing list pgsql-bugs

From Thomas Munro
Subject Re: BUG #17828: postgres_fdw leaks file descriptors on error and aborts aborted transaction in lack of fds
Date
Msg-id CA+hUKGJngeN3Sm9g2QTQd3-HxnRm-0aaPzYFJ=hCmh+T9F8Sjw@mail.gmail.com
Whole thread Raw
In response to Re: BUG #17828: postgres_fdw leaks file descriptors on error and aborts aborted transaction in lack of fds  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
On Fri, Feb 9, 2024 at 11:06 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Andres Freund <andres@anarazel.de> writes:
> > I also wonder if postgres_fdw should strive to use a longer lived wait event
> > set. For efficiency, if nothing else? That'd avoid the need to create one
> > during error handling.
>
> Seems like a plausible idea.  Having to acquire resources to clean up
> an error is an anti-pattern for sure.

FWIW, WRT to the long lived WES idea, I have had patches to explore
several different ways to do that (as I already did successfully for
other areas), and I will write about that again later, but I concluded
that we needed to fix this Windows nonsense first:
https://commitfest.postgresql.org/46/3523/  (That got withdrawn for
being too slow, but I'll resubmit it soon enough...)



pgsql-bugs by date:

Previous
From: Andres Freund
Date:
Subject: Re: BUG #17828: postgres_fdw leaks file descriptors on error and aborts aborted transaction in lack of fds
Next
From: Tom Lane
Date:
Subject: Re: BUG #17828: postgres_fdw leaks file descriptors on error and aborts aborted transaction in lack of fds