Re: Using AF_UNIX sockets always for tests on Windows - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Using AF_UNIX sockets always for tests on Windows
Date
Msg-id CA+hUKGJkBm0kKLrZax_SSMPYBzZtaeU5CsiUj4NUm9LBp4YnfA@mail.gmail.com
Whole thread Raw
In response to Re: Using AF_UNIX sockets always for tests on Windows  (Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>)
Responses Re: Using AF_UNIX sockets always for tests on Windows  (vignesh C <vignesh21@gmail.com>)
List pgsql-hackers
Thanks Tom, Andres, Juan José, Andrew for your feedback.  I agree that
it's a better "OS harmonisation" outcome if we can choose both ways on
both OSes.  I will leave the 0003 patch aside for now due to lack of
time, but here's a rebase of the first two patches.  Since this is
really just more cleanup-obsolete-stuff background work, I'm going to
move it to the next CF.

0001 -- Teach mkdtemp() to care about permissions on Windows.
Reviewed by Juan José, who confirmed my blind-coded understanding and
showed an alternative version but didn't suggest doing it that way.
It's a little confusing that NULL "attributes" means something
different from NULL "descriptor", so I figured I should highlight that
difference more clearly with some new comments.  I guess one question
is "why should we expect the calling process to have the default
access token?"

0002 -- Use AF_UNIX for pg_regress.  This one removes a couple of
hundred Windows-only lines that set up SSPI stuff, and some comments
about a signal handling hazard that -- as far as I can tell by reading
manuals -- was never really true.

0003 -- TAP testing adjustments needs some more work based on feedback
already given, not included in this revision.

Attachment

pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: Commitfest 2023-03 starting tomorrow!
Next
From: Michael Paquier
Date:
Subject: Re: Reconcile stats in find_tabstat_entry() and get rid of PgStat_BackendFunctionEntry