Postgres Pro
Downloads
Home   >   mailing lists

Re: Confine vacuum skip logic to lazy_scan_skip - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Confine vacuum skip logic to lazy_scan_skip
Date
Msg-id CA+hUKGJSZbFfcg7a7x50Q_8b9_iv_ycXUuMY2Wjm5ar_UgVzOQ@mail.gmail.com
Whole thread Raw
In response to Re: Confine vacuum skip logic to lazy_scan_skip  (Melanie Plageman <melanieplageman@gmail.com>)
Responses Re: Confine vacuum skip logic to lazy_scan_skip
List pgsql-hackers
Tree view 
On Fri, Feb 14, 2025 at 12:11 PM Melanie Plageman
<melanieplageman@gmail.com> wrote:
> I've done some clean-up including incorporating a few off-list pieces
> of minor feedback from Andres.

I've been poking, reading, and trying out these patches.  They look good to me.

Tiny nit, maybe this comment could say something less obvious, cf the
similar comment near the other stream:

+       /* Set up the read stream */
+       stream = read_stream_begin_relation(READ_STREAM_MAINTENANCE,

I don't really love the cumbersome casting required around
per_buffer_data, but that's not your patches' fault (hmm, wonder what
we can do to improve that).

pgsql-hackers by date:

Previous
From: Hannu Krosing
Date:
Subject: Re: Is pgAdmin the only front-end to PostgreSQL debugger ? And is "a working pl/pgsql debugger" something core should care to maintain ?
Next
From: Melanie Plageman
Date:
Subject: Re: Confine vacuum skip logic to lazy_scan_skip