Postgres Pro
Downloads
Home   >   mailing lists

Re: check_strxfrm_bug() - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: check_strxfrm_bug()
Date
Msg-id CA+hUKGJ=+rE2f2CKqcFLqEDvc9mB-LxNDsbyZoBNcusTeTW=Ew@mail.gmail.com
Whole thread Raw
In response to Re: check_strxfrm_bug()  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
Tree view 
On Tue, Jul 11, 2023 at 2:28 AM Peter Eisentraut <peter@eisentraut.org> wrote:
> This looks sensible to me.
>
> If we ever need mbstowcs_l() etc. outside of pg_locale.c, then the
> proper way would be to make a mbstowcs_l.c file in src/port/.
>
> But I like your approach for now because it moves us more firmly into
> the direction of having it contained in pg_locale.c, instead of having
> some knowledge global and some local.

Thanks.  Pushed.

That leaves only one further cleanup opportunity from discussion this
thread, for future work: a TRUST_STRXFRM-ectomy.

pgsql-hackers by date:

Previous
From: Nikolay Samokhvalov
Date:
Subject: Re: pg_upgrade instructions involving "rsync --size-only" might lead to standby corruption?
Next
From: Michael Paquier
Date:
Subject: Re: Generating code for query jumbling through gen_node_support.pl