Re: An out-of-date comment in nodeIndexonlyscan.c - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: An out-of-date comment in nodeIndexonlyscan.c
Date
Msg-id CA+hUKGJ0woC8m8c9eZzTyVUQi+8D8Pibjo7XVTu83kf8SfQqLg@mail.gmail.com
Whole thread Raw
In response to Re: An out-of-date comment in nodeIndexonlyscan.c  (Ashwin Agrawal <aagrawal@pivotal.io>)
Responses Re: An out-of-date comment in nodeIndexonlyscan.c
List pgsql-hackers
On Fri, Jun 28, 2019 at 12:55 PM Ashwin Agrawal <aagrawal@pivotal.io> wrote:
> On Thu, Jun 27, 2019 at 4:33 PM Thomas Munro <thomas.munro@gmail.com> wrote:
>>
>> Here's a patch I'd like to commit to fix the comment.  We could look
>> at improving the actual code after
>> https://commitfest.postgresql.org/23/2169/ is done.
>
> Change looks good to me.

... and here is the corresponding code change, with a test to
demonstrate the change.

I'm working on a proof-of-concept to skip the btree page lock
sometimes too, which seems promising, but it requires some planner
work which has temporarily pretzeled my brain.

Attachment

pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: pg_filenode_relation(0,0) elog
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] Fix buffer not null terminated on (ecpg lib)