Postgres Pro
Downloads
Home   >   mailing lists

Re: BufFileRead() error signalling - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: BufFileRead() error signalling
Date
Msg-id CA+hUKG+fAjDDGxzYT7ya_gTBniLGjx0hZ93KX+EgEEMfF7cXtA@mail.gmail.com
Whole thread Raw
In response to Re: BufFileRead() error signalling  (Ibrar Ahmed <ibrar.ahmad@gmail.com>)
Responses Re: BufFileRead() error signalling  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tree view 
On Wed, Dec 11, 2019 at 2:07 AM Ibrar Ahmed <ibrar.ahmad@gmail.com> wrote:
> You are checking file->dirty twice, first before calling the function and within the function too. Same for the
Assert.For example.
 

True.  Thanks for the review.  Before I post a new version, any
opinions on whether to back-patch, and whether to do 0003 in master
only, or at all?

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Parallel leader process info in EXPLAIN
Next
From: Amit Kapila
Date:
Subject: Re: Error message inconsistency