Postgres Pro
Downloads
Home   >   mailing lists

Re: consider -Wmissing-variable-declarations - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: consider -Wmissing-variable-declarations
Date
Msg-id CA+hUKG+YVt5MBD-w0HyHpsGb4U8RNge3DvAbDmOFy_epGhZ2Mg@mail.gmail.com
Whole thread Raw
In response to Re: consider -Wmissing-variable-declarations  (Andres Freund <andres@anarazel.de>)
Responses Re: consider -Wmissing-variable-declarations
List pgsql-hackers
Tree view 
On Wed, Jun 19, 2024 at 3:02 AM Andres Freund <andres@anarazel.de> wrote:
> > -const char *EAN13_range[][2] = {
> > +static const char *EAN13_range[][2] = {
> >       {"000", "019"},                         /* GS1 US */
> >       {"020", "029"},                         /* Restricted distribution (MO defined) */
> >       {"030", "039"},                         /* GS1 US */
>
> > -const char *ISBN_range[][2] = {
> > +static const char *ISBN_range[][2] = {
> >       {"0-00", "0-19"},
> >       {"0-200", "0-699"},
> >       {"0-7000", "0-8499"},
> > @@ -967,7 +967,7 @@ const char *ISBN_range[][2] = {
> >   */

FYI these ones generate -Wunused-variable warnings from headerscheck
on CI, though it doesn't fail the task.  Hmm, these aren't really
headers, are they?

pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: Significant Execution Time Difference Between PG13.14 and PG16.4 for Query on information_schema Tables.
Next
From: Bertrand Drouvot
Date:
Subject: Re: Flush pgstats file during checkpoints