Postgres Pro
Downloads
Home   >   mailing lists

Re: Yet another fast GiST build (typo) - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Yet another fast GiST build (typo)
Date
Msg-id CA+hUKG+UoDyKgvO9BLE7543D1Yu8qQoBHAZRDSo_ETowja6GHw@mail.gmail.com
Whole thread Raw
In response to Re: Yet another fast GiST build (typo)  ("Andrey M. Borodin" <x4mmm@yandex-team.ru>)
Responses Re: Yet another fast GiST build (typo)  ("Andrey M. Borodin" <x4mmm@yandex-team.ru>)
List pgsql-hackers
Tree view 
On Fri, Jul 10, 2020 at 6:55 PM Andrey M. Borodin <x4mmm@yandex-team.ru> wrote:
> Thanks! Fixed.

It's not a bug, but I think those 64 bit constants should be wrapped
in UINT64CONST(), following our convention.

I'm confused about these two patches: 0001 introduces
gist_point_fastcmp(), but then 0002 changes it to gist_bbox_fastcmp().
Maybe you intended to keep both of them?  Also 0002 seems to have
fixups for 0001 squashed into it.

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Default setting for enable_hashagg_disk
Next
From: Michael Paquier
Date:
Subject: Re: Ought to use heap_multi_insert() for pg_attribute/depend insertions?