Re: [PATCH] Comments related to " buffer descriptors“ cache line size" - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: [PATCH] Comments related to " buffer descriptors“ cache line size"
Date
Msg-id CA+hUKG+N3fUcUy_VbBj938M2zjTn_ir6rCA9YR2DN_nY5NMrgQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Comments related to " buffer descriptors“ cache line size"  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On Sat, Sep 5, 2020 at 5:28 AM Bruce Momjian <bruce@momjian.us> wrote:
> On Fri, Sep  4, 2020 at 11:31:55PM +0800, Kelly Min wrote:
> > I found a comment error in buffer descriptors comment. The cache line size is
> > 64 bytes, not 64 bits
>
> Thanks, fix applied to all active branches.

I find it a bit strange that our PG_CACHE_LINE_SIZE macro is defined
to be 128.  Whether that exaggerated number (unless you're on POWER,
where it's true) makes sense depends on what your goals are, as this
usage of hard-coded 64 shows...



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: BUG #16419: wrong parsing BC year in to_date() function
Next
From: Alvaro Herrera
Date:
Subject: Re: A micro-optimisation for walkdir()