V5 is ok (aside for LLVM 14 deprecated warnings, but that's another problem) with meson compile and meson test on Ubuntu 20.04.2.
Code fits well and looks standart, --help explain what it does clearly, and documentation is ok (but as a Français, I'm not an expert in English).
Stéphane
Le lun. 13 mars 2023 à 16:15, Gilles Darold <gilles@migops.com> a écrit :
Le 12/03/2023 à 19:05, Stéphane Tachoires a écrit :
Hi Gilles,
On Ubuntu 22.04.2 all deb's updated, I have an error on a test
I'll try to find where and why, but I think you should know first.
1/1 postgresql:pg_dump / pg_dump/002_pg_dump ERROR 24.40s exit status 1 ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― ✀ ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― stderr: # Failed test 'only_dump_measurement: should dump CREATE TABLE test_compression' # at /media/hddisk/stephane/postgresql/src/postgresql/src/bin/pg_dump/t/002_pg_dump.pl line 4729. # Review only_dump_measurement results in /media/hddisk/stephane/postgresql/build/testrun/pg_dump/002_pg_dump/data/tmp_test_iJxJ # Looks like you failed 1 test of 10264.
Hi Stephane,
Odd, I do not have this error when running make installcheck, I have the same OS version as you.
+++ tap check in src/bin/pg_dump +++ t/001_basic.pl ................ ok t/002_pg_dump.pl .............. ok t/003_pg_dump_with_server.pl .. ok t/010_dump_connstr.pl ......... ok All tests successful. Files=4, Tests=9531, 11 wallclock secs ( 0.33 usr 0.04 sys + 3.05 cusr 1.22 csys = 4.64 CPU) Result: PASS
Anyway this test must be fixed and this is done in version v5 of the patch attached here.
Thanks for the review.
--
Gilles Darold
--
"Où se posaient les hirondelles avant l'invention du téléphone ?"
