On Wed, 18 Dec 2019 at 03:39, Mahendra Singh <mahi6run@gmail.com> wrote:
>
>
> Thanks for updated patches. I verified my all reported issues and all are fixed in v36 patch set.
>
> Below are some review comments:
> 1.
> + /* cap by max_parallel_maintenace_workers */
> + parallel_workers = Min(parallel_workers, max_parallel_maintenance_workers);
>
> Here, spell of max_parallel_maintenace_workers is wrong. (correct: max_parallel_maintenance_workers)
>
> 2.
> + * size of stats for each index. Also, this function Since currently we don't support parallel vacuum
> + * for autovacuum we don't need to care about autovacuum_work_mem
>
> Here, I think, 1st line should be changed because it is not looking correct as grammatically.
Thank you for reviewing and testing this patch. I'll incorporate your
comments in the next version patch.
Regards,
--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
