Re: [HACKERS] [PATCH] Call RelationDropStorage() for broader range ofobject drops. - Mailing list pgsql-hackers

From Hadi Moshayedi
Subject Re: [HACKERS] [PATCH] Call RelationDropStorage() for broader range ofobject drops.
Date
Msg-id CA+_kT_f1S4iG=udsM3kq3JwbcbZGKTQJTovyY8m1wnCuC5OUyQ@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] [PATCH] Call RelationDropStorage() for broader range ofobject drops.  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [HACKERS] [PATCH] Call RelationDropStorage() for broader range ofobject drops.  (Hadi Moshayedi <hadi@citusdata.com>)
List pgsql-hackers
On Wed, Sep 13, 2017 at 12:12 AM, Michael Paquier <michael.paquier@gmail.com> wrote: 
Foreign tables do not have physical storage assigned to by default. At
least heap_create() tells so, create_storage being set to false for a
foreign table. So there is nothing to clean up normally. Or is
cstore_fdw using directly heap_create with its own relfilenode set,
creating a physical storage?

cstore_fdw (in store_data_in_internal_storage branch) calls RelationCreateStorage() after CREATE FOREIGN TABLE completes [1]. Later it also creates the FSM fork and uses it for storing some metadata.


pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: [HACKERS] Warnings "unrecognized node type" for some DDLs with log_statement = 'ddl'
Next
From: Hadi Moshayedi
Date:
Subject: Re: [HACKERS] [PATCH] Call RelationDropStorage() for broader range ofobject drops.