Home > mailing lists

[HACKERS] [PATCH] Make ExplainBeginGroup()/ExplainEndGroup() public. - Mailing list pgsql-hackers

From	Hadi Moshayedi
Subject	[HACKERS] [PATCH] Make ExplainBeginGroup()/ExplainEndGroup() public.
Date	July 21, 2017 20:09:25
Msg-id	CA+_kT_cCew4OKqTL-ueNndEL1jWYu+3e9RdLZP-_WR1KbONzfA@mail.gmail.com Whole thread Raw
Responses	Re: [HACKERS] [PATCH] Make ExplainBeginGroup()/ExplainEndGroup() public. Re: [HACKERS] [PATCH] Make ExplainBeginGroup()/ExplainEndGroup()public.
List	pgsql-hackers

Tree view

Hello,

The attached patch moves declarations of ExplainBeginGroup()/ExplainEndGroup() from explain.c to explain.h.

This can be useful for extensions that need explain groups in their custom-scan explain output.

For example, Citus uses groups in its custom explain outputs [1]. But it achieves it by having a copy of
ExplainBeginGroup()/ExplainEndGroup() in its source code, which is not the best way.

Please review.

[1] https://github.com/citusdata/citus/blob/master/src/backend/distributed/planner/multi_explain.c

Thanks,

Hadi

Attachment

make_explainbeginendgroup_public.patch

pgsql-hackers by date:

From: Yugo Nagata
Date: 21 July 2017, 19:58:51
Subject: Re: [HACKERS] [PATCH] A hook for session start

From: "Joshua D. Drake"
Date: 21 July 2017, 20:21:10
Subject: Re: [HACKERS] autovacuum can't keep up, bloat just continues to rise

[HACKERS] [PATCH] Make ExplainBeginGroup()/ExplainEndGroup() public. - Mailing list pgsql-hackers

Attachment

Previous

Next